Add TypeScript support, closes #285 #406
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goto-bus-stop
commented
Jan 31, 2018
If `typescript` is installed, add the tsify plugin. If a syntax error occurs in a `.ts` file, recommend installing `typescript`. TODO: Catch and format errors from the typescript compiler.
goto-bus-stop
force-pushed
the
typescript
branch
from
2f08575 to
50ee86b
Compare
goto-bus-stop
changed the title
Member
Author
|
Now also formatting typescript errors:
And did some work on syntax error messages for javascript too: |
Member
|
@goto-bus-stop sick work! Question tho: none of this would work with server rendering, right? |
Member
Author
|
Afraid that's correct 😄 that is also going to be an issue for react support with babel. Not sure what to do about that yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
typescriptis installed, add the tsify plugin.If a syntax error occurs in a
.tsfile, recommend installingtypescript.TODO: Catch and format errors from the typescript compiler…